ARCHIVE: Snarkpit v6 Bugs
locked
Quote
Re: ARCHIVE: Snarkpit v6 Bugs
Posted by larchy on Tue Feb 3rd at 9:38am 2009


Quoting Riven
What happened to my signature? It's blank now? smiley


One of the user database copies didn't fully complete - everything should be ok now.

Quoting Riven
The registration date for users listed on posts are all the same default "1969" date. But they're correct in profiles.


Just the column name changed on the database table and the script wasn't updated... if you see that anywhere else lemme know so I can make the change.

Quoting Riven

OMG! you can view between pages! What is this world coming to!? smiley
I was checking my control panel in one FireFox tab, and had the HL forum open in another. After noticing my sig was gone, I changed the number of posts from 20 to 80 again and applied. When I switched to the HL forum, I went to the next page, and got some weird paging results as you can see.


It's not really a bug tbh. Say you are viewing 20 posts per page and are on page 5, the topic offset (the number from which records start being returned) would be 80 (ie you skip the first 80 posts and view 80-100). If you change the number of posts viewed to 30 and refresh the page then the offset is still 80, but because it's 30 posts per page it means you're now viewing page 2.67

If you do it with even numbers then you won't get a fraction, although all the page numbers will change.

Anyway, added code to take out the decimal places, but the way it's working is ok/the same.

Quoting Riven

A lot of the posts are missing their reply values and the author values. After page 3, I think they all are missing. -Is that too from the incomplete DB?


Yeah, just stuff missing from the forums/topics/posts tables, no worries smiley

----
aha, just tried to post and it broke! smiley fixed smiley




Quote
Re: ARCHIVE: Snarkpit v6 Bugs
Posted by larchy on Tue Feb 3rd at 5:09pm 2009


Quoting Riven
When viewing pictures on map profiles, if you press the button to view a different picture in the list, and then click on that picture to open it in a new window, the window will always show the first picture for that map, no matter which one you clicked on in the list. This is an issue on the other version of the site as well.


Fixed! (Ctrl+f5 to refresh the js if it doesn't work!)




Quote
Re: ARCHIVE: Snarkpit v6 Bugs
Posted by larchy on Tue Feb 3rd at 8:06pm 2009


Quoting Riven
When sorting by highest rated maps under ALL games it didn't put the highest rated maps first


I know I mentioned this before, but there was actually a problem with the way I'd designed the system that I didn't figure out earlier on account of me being thick.

There may still be some maps out of order when you sort by this option (and articles/dls for that matter), but I have now corrected the rating system and made it so that it is self correcting - that is, everytime someone rates a map the value which determines the sort order is recalculated, so if there are any maps being shown out of order just rate them and it'll fix it!




Quote
Re: ARCHIVE: Snarkpit v6 Bugs
Posted by Riven on Wed Feb 4th at 8:23pm 2009


I don't think smileys work in the discussion sections on map profiles...





Quote
Re: ARCHIVE: Snarkpit v6 Bugs
Posted by larchy on Thu Feb 5th at 8:51am 2009


Just quickly checked and they do in the map descriptions and the discussion thread underneath the map.... is that where you mean?

They don't on the overlay text, but that's intentional.




Quote
Re: ARCHIVE: Snarkpit v6 Bugs
Posted by Riven on Thu Feb 5th at 9:26pm 2009


Ok, yea, you're right. They do work in the map descriptions and discussion threads underneath maps. I had thought I spotted a text smiley and figured something wasn't working right, but now that I've had time to double check, I don't think there is an issue. -False Alarm! smiley





Quote
Re: ARCHIVE: Snarkpit v6 Bugs
Posted by Riven on Mon Feb 9th at 3:23pm 2009


This thread and the "all visitors please read" thread are missing their paging buttons in the thread list on the general banter forum page.

BTW, I like the new "hot topic" icon! Sweet!






Quote
Re: ARCHIVE: Snarkpit v6 Bugs
Posted by larchy on Mon Feb 9th at 3:52pm 2009


whaaaa?



smiley

[Edit: ahhhh it was because it was using the number of topics to paginate the threads... 'cos you can increase that in your user profile now and it ballsed it up. Fixed!]



Also, I haven't done anything for the past few days 'cos I've been horrendously ill D: Progress will hopefully resume shortly.




Quote
Re: ARCHIVE: Snarkpit v6 Bugs
Posted by larchy on Tue Feb 10th at 11:30am 2009


I've started doing the laborious task of cross-browser fixes, and have redone quite a lot of css and some actual layout code to get IE6 working - ctrl+f5 to refresh your stylesheets if the forums look a mess.

The new code that pops up the right map screenshot from the map page needed to be redone too, and I'm having to call a function constructor to get the code to work in IE 6 (because it doesn't support DOM1+), which is slow because it forces an eval... but at least it works and there isn't really much js going on anyway so shouldn't be a problem.

Also, your avatar looks crap on IE Riven because it doesn't support the transparency.




Quote
Re: ARCHIVE: Snarkpit v6 Bugs
Posted by Riven on Wed Feb 11th at 2:49am 2009


Excuse YOU Sir! But I think my avatar looks just fine!
-I polish it every day!

-Na, I bet the transparency is double crap in IE6, -Oh well smiley I wonder what the percentage of users still use IE6 and earlier are? smiley






Quote
Re: ARCHIVE: Snarkpit v6 Bugs
Posted by Riven on Wed Feb 11th at 4:01am 2009


OK, a couple of things...

clicking on any PM user icon brings me to a "Find User Failed" page: http://opal.lunarbreeze.com/~snark3/index.php?p=cp&pma=new&pmr=6381

Ok, when I was testing the $M rate page for the super admin panel, I changed the fixed rates for downloads and articles to 10 from 0 and updated it. When checking my own profile snarkmarks, it says I'm still receiving none from downloads even though I have 1. -Does that download need to have at least 1 rating in order for the fixed rate to count at all? I thought fixed rates are given automatically after uploading that item, and then the percentage from ratings is added to that fixed rate?

So, shouldn't my number have changed whenever I updated the fixed rate for downloads?

Also, I've gotten another request from a user about their account not wanting to work for them. I'll PM you the details on the globat site, but this seems to be a re-occurring problem. Is there something more to this than the person forgetting their username or password? -And has there been any fixes for it on this new version of the site if there are any bugs involved?






Quote
Re: ARCHIVE: Snarkpit v6 Bugs
Posted by Le Chief on Wed Feb 11th at 5:19am 2009


Quoting Riven
Excuse YOU Sir! But I think my avatar looks just fine!
-I polish it every day!


smileysmileysmileysmileysmileysmileysmileysmileysmileysmiley






Quote
Re: ARCHIVE: Snarkpit v6 Bugs
Posted by larchy on Wed Feb 11th at 8:25am 2009


I redid the snarkmark code so that it now stores a fixed value. This is updated if you visit the control panel > snarkmark link, and will also be when you add any new content.

But right now you may no longer immediately see the effects when you change the snarkmark values... the reason I did this is because calculating everyone's rating dynamically is expensive as you have to pull all the stuff they've ever uploaded from three different tables, loop through it and work out the values... I wrote a script to resync everyone's rating but haven't put it into an admin control yet - but I will so you can resync everyone manually. In the meantime the resync on that cp page will act as a sort of occasional resync when users visit it.


_________

Yes there is a problem with accounts and reactivating on globat. I have pulled my hair out trying to get things to work because what does work one day doesn't work the next. They have changed the way the server handles $_GET and $_POST requests at least 3 times (this has to do with why the slashes randomly appear in posts), some days the mail function plain doesn't work so noone gets emails, then it suddenly does, sometimes it sends a glut of backlogged ones... but even then with the activation emails the code is wrong because the database query fails... I've tried to fix things as best I can but I honestly feel like Sisyphus

The code for creating/reactivating etc has been redone for this new site - it had to be because I've completely changed the user database. I've redone the way the activations system works anyway.... the system on globat is just the code from the old site by leperous because I didn't want any problems so just stuck with what worked... but obviously it hasn't gone well! I've also added a contact page and additional error/help pages if something goes wrong so that it's easier for ppl to contact me if they are having trouble.

--------

The globat code is basically abandoned as far as I'm concerned, I'm sick of coding around their fking crappy server bollox and downloading my own code from there to find out it's had extra stuff added to the start and end of it (no kidding - remember when the original site had those hidden porn links appear in the code this time last year? and it was a cross site scripting attack that had added the code to the index files? I'm sure globat's servers are compromised)

-----

thanks for the pm link bug, will fix




Quote
Re: ARCHIVE: Snarkpit v6 Bugs
Posted by larchy on Wed Feb 11th at 9:00am 2009


Ok m8 I dunno, I've just changed my email, my pw, and used the password retrieve thing and it worked each time... so fkknows tbh, dunno whats happening.


I've added my email address to the "activation failed" error message so they can email me directly if they have a problem.




Quote
Re: ARCHIVE: Snarkpit v6 Bugs
Posted by larchy on Wed Feb 11th at 9:19am 2009


Here's the sort of crap randomly added by globat:

Code
<?php @register_shutdown_function("__sfd1229464065__");function __sfd1229464065__() { global $__sdv1229464065__; if (!empty($__sdv1229464065__)) return; $__sdv1229464065__=1; echo <<<DOC__DOC

DOC__DOC;
} ?>
<?php @register_shutdown_function("__sfd1228928734__");function __sfd1228928734__() { global $__sdv1228928734__; if (!empty($__sdv1228928734__)) return; $__sdv1228928734__=1; echo <<<DOC__DOC

DOC__DOC;
} ?>


Which makes the script call a function (or functions) every time it finishes running, and fk knows what they're doing 'cos the names are totally screwy.

Oh, and you can access the phpymyadmin page for the globat database just by going to the correct URL - no password, no login, nothing, totally unprotected. Sooner we're off them the better tbh.




Quote
Re: ARCHIVE: Snarkpit v6 Bugs
Posted by larchy on Wed Feb 11th at 1:02pm 2009


Quoting Riven
I wonder what the percentage of users still use IE6 and earlier are? smiley


About 30%. Unfortunately a lot of companies are IE6 only as their company intranets only work with IE6 and they daren't change it. Some just also don't want to have to deploy IE7 due tot he work involved, and they won't use anything other than IE because the likes of Firefox's server deployment features are utter crap.

Firefox is around 20%, Opera < 1%, Chrome and Safari abour 3-4%, and the remaining largest single chunk is IE7

However on technology related sites (ie sites whose users have any sort of basic clue) Firefox is about 50%, IE about 20% and the rest mostly Safari with some Opera and (increasingly) Chrome

For snarkpit about 22% is IE, 34% Firefox, 3% Opera, 3% Safari and (helpfully) 36% 'unknown', but I put this down to globat's webstats being crap. I'd guess it's mostly made up of Firefox running extensions and possibly Chrome.





Quote
Re: ARCHIVE: Snarkpit v6 Bugs
Posted by larchy on Wed Feb 11th at 1:16pm 2009


Quoting Riven
clicking on any PM user icon brings me to a "Find User Failed" page: http://opal.lunarbreeze.com/~snark3/index.php?p=cp&pma=new&pmr=6381


pm system hadn't been changed to use the new user accounts database. Fixed.




Quote
Re: ARCHIVE: Snarkpit v6 Bugs
Posted by Riven on Wed Feb 11th at 9:01pm 2009


BTW, the user who can't login to their account is on the old pit. I understand you're leaving to the dogs, so I'll tell him to wait for the time being.

The new pit here on lunarpages, has already proved its superiority. One of our older members, fatstrings was having trouble logging in on the old site, having the same problem as the member I just described, and he couldn't re-activate or anything like that. He tried all the fixes but no avail. I gave him the beta address and told him to logon here instead, and low & behold it worked first time around! -Hopefully we'll be seeing him on here soon!

So, that (to me) proves the new system you coded is much better. If I get any more complaints, I'll give them an estimated wait period. -Do you want to start the countdown? I realize we're waiting on Lep to do something for Gwil before we can make the actual switch, but I'd like to know when you will be ready?

Oh, and also, I still don't see the updated $M on my control panel to reflect the 10 recieved from my one 'download'. -I thought visiting that page will refresh my profile's $M? -Or do I actually need to do a global manual resync?






Quote
Re: ARCHIVE: Snarkpit v6 Bugs
Posted by larchy on Wed Feb 11th at 9:10pm 2009


I tried all the account activation stuff this mornign on globat and it worked for me tho D:

--------------

hmmm well I don't think making sure all the various browsers work will take too long... and I want to add a couple of things still. Could do it next week sometime maybe?

AFAIK all that has to be done with the domain is to update the nameservers, and once that's done its 2-3 days to propagate... and i'll have to take the globat site off so that I can take a snapshot of the database and then transfer everything using the monstrous uber-scripts of database reconstructingness... not looking forward to that!



Would be good if a few more people got the address for here because they'll inevitably find bugs that we've missed.




Quote
Re: ARCHIVE: Snarkpit v6 Bugs
Posted by reaper47 on Wed Feb 11th at 11:02pm 2009


Hey there!

Upon logging in the first time (ever), I was sent to this page:

"Action denied!

You must wait at least 1 seconds before making another submission!

Return to previous page ยป"

I am logged in now, though, and everything works fine, it was just a weird welcome message.





locked